Skip to content

Conversation

@sudiptatj
Copy link
Contributor

@sudiptatj sudiptatj changed the base branch from main to develop November 19, 2024 18:32
Copy link
Member

@eupharis eupharis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me! Will defer to Aaron for final code review. Unless his Java is as bad as mine is, and then I can take a closer look 😁

Copy link
Member

@aarongoin aarongoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	README.md
#	commons/pom.xml
#	library/pom.xml
#	parent-pom/pom.xml
#	polyapi-maven-plugin/pom.xml
#	pom.xml
@sudiptatj sudiptatj merged commit 7cd7d89 into develop Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants